Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Match NBT/ Ignore NBT", "Match Meta/Ignore Meta" options in Item Loader and Unloader #59

Merged
merged 9 commits into from
Jul 13, 2024

Conversation

TimeConqueror
Copy link

The Issue
The item loaders are pretty dumb, since they can't filter items by NBT, which is really nice for filtering super tanks.

The Proposal
Add the new button, which enables NBT check (texture was stolen from EnderIO 😄 )

image
image

Possible Side Effects
Since the gui was changed, all texturepacks will use the default texture instead of custom one.

Alternatives

@TimeConqueror TimeConqueror requested a review from a team June 26, 2024 00:03
@TimeConqueror TimeConqueror self-assigned this Jun 26, 2024
@TimeConqueror
Copy link
Author

Also added the same mechanic for Metadata
image

@TimeConqueror TimeConqueror changed the title Add "Match NBT/ Ignore NBT" option in Item Loader and Unloader Add "Match NBT/ Ignore NBT", "Match Meta/Ignore Meta" options in Item Loader and Unloader Jun 26, 2024
Copy link

Warning: 2 uncommitted changes
#60

@Ethryan
Copy link

Ethryan commented Jun 27, 2024

Damn it, This is a reminder for me to update my texture pack gui.

github-actions bot and others added 5 commits June 27, 2024 06:58
Co-authored-by: GitHub GTNH Actions <>
(cherry picked from commit 2c4d39b)
(cherry picked from commit 3891782)
Co-authored-by: Alexander Anishin <[email protected]>
Copy link

Warning: 2 uncommitted changes
#61

Co-authored-by: GitHub GTNH Actions <>
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to remove the last argument of InvTools.isItemEqual calls where it doesn't break the logic. This will reduce the amount of unnecessary changes, but anyway, PR is ready in its current state.

@Dream-Master Dream-Master merged commit 4996209 into master Jul 13, 2024
1 check passed
@Dream-Master Dream-Master deleted the itemloader-nbt-check branch July 13, 2024 08:55
@Dream-Master
Copy link
Member

@TimeConqueror feel free add more code and open a new pr if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants