-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Match NBT/ Ignore NBT", "Match Meta/Ignore Meta" options in Item Loader and Unloader #59
Conversation
Warning: 2 uncommitted changes |
Damn it, This is a reminder for me to update my texture pack gui. |
src/main/java/mods/railcraft/common/util/inventory/InvTools.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Anishin <[email protected]>
Warning: 2 uncommitted changes |
Co-authored-by: GitHub GTNH Actions <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be nice to remove the last argument of InvTools.isItemEqual
calls where it doesn't break the logic. This will reduce the amount of unnecessary changes, but anyway, PR is ready in its current state.
@TimeConqueror feel free add more code and open a new pr if necessary |
The Issue
The item loaders are pretty dumb, since they can't filter items by NBT, which is really nice for filtering super tanks.
The Proposal
Add the new button, which enables NBT check (texture was stolen from EnderIO 😄 )
Possible Side Effects
Since the gui was changed, all texturepacks will use the default texture instead of custom one.
Alternatives