Change fake NibbleArray to not use empty byte array for Thermos compat #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a crash with Thermos where it is incompatible with receiving a completely empty(but not null) byte array for the underlying data array of a
NibbleArray. This is only used in NEID to trick minecraft into thinking the length of theNibbleArrayis zero, initializing in this way accomplishes the same but shouldn't break Thermos.The
MixinChunkchange wouldn't actually need to change, but figured I'd keep the approaches in sync since they do more or less the exact same thing asMixinS21PacketChunkDatawhich is the one that actually breaks Thermos.