Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try fix lma #10

Merged
merged 5 commits into from
Sep 20, 2024
Merged

try fix lma #10

merged 5 commits into from
Sep 20, 2024

Conversation

Glease
Copy link

@Glease Glease commented Sep 2, 2024 •
edited
Loading

  1. fix lag on pattern change - still might lags on initial chunk load, but won't lag more than enough sb assembler+interfaces to hold the same amount of patterns
  2. fix lag during idle
  3. remove 256 parallel limit
  4. fix not returning crafting tools. most notably, empty cell in recipe of IV~UV Power Transformer.

remove deprecation mark since none of the initial concerns, lag, tool vanishing and lack of kotlin developer, is still valid

holding this draft for now since there is this great renaming thing going on

@Glease Glease marked this pull request as draft September 2, 2024 16:59
@Glease
adapt to great renaming
b2e0250
@Glease
Merge remote-tracking branch 'origin/master' into lma-fixes
4ce1332 
# Conflicts:
#	dependencies.gradle
#	src/main/kotlin/com/muxiu1997/mxrandom/loader/GTMetaTileEntityLoader.kt
#	src/main/kotlin/com/muxiu1997/mxrandom/metatileentity/MTELargeMolecularAssembler.kt
@Glease
Merge branch 'master' into lma-fixes
a3745f8
@Glease Glease marked this pull request as ready for review September 19, 2024 17:31
@Glease Glease requested a review from a team September 19, 2024 17:31
@Glease Glease mentioned this pull request Sep 19, 2024
Open
NotAPenguin0
NotAPenguin0 approved these changes Sep 19, 2024
View reviewed changes
Copy link

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small remark that seems a bit odd to me

src/main/kotlin/com/muxiu1997/mxrandom/metatileentity/MTELargeMolecularAssembler.kt Outdated Show resolved Hide resolved
@Dream-Master
Copy link
Member

@Glease

@boubou19 boubou19 merged commit 187d6ab into master Sep 20, 2024
1 check passed
@boubou19 boubou19 deleted the lma-fixes branch September 20, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAPenguin0 NotAPenguin0 NotAPenguin0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Glease @Dream-Master @NotAPenguin0 @boubou19