Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making extractor Mk1-Mk2 useful #58

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Conversation

TimeConqueror
Copy link

@TimeConqueror TimeConqueror commented Jul 21, 2024

with GTNewHorizons/NewHorizonsCoreMod#904
with GTNewHorizons/GT5-Unofficial#2746

This is a part of big Logistics Pipes easifying.
Before the extractor pipes Mk1-Mk2 were pretty useless with there advanced version, because they were too slow.
This commit makes change to their speed:

  • Extractor Mk1 / Advanced Extractor Mk1: 1 item every 5 sec -> 5 items every sec
  • Extractor Mk2 / Advanced Extractor Mk2: 1 item every sec -> 32 items every sec

Without changes:

  • Extractor Mk3 / Advanced Extractor Mk3: 1280 items every sec (64 items every tick).

@TimeConqueror TimeConqueror self-assigned this Jul 21, 2024
@Dream-Master Dream-Master requested a review from a team July 21, 2024 14:15
@Dream-Master
Copy link
Member

ok from my side but i want other to check as well

@Pxx500
Copy link
Member

Pxx500 commented Jul 21, 2024

does https://github.com/GTNewHorizons/NewHorizonsCoreMod/pull/904/files change recipes for those cards?

@TimeConqueror TimeConqueror changed the base branch from dev to master July 21, 2024 14:43
@TimeConqueror
Copy link
Author

TimeConqueror commented Jul 21, 2024

does https://github.com/GTNewHorizons/NewHorizonsCoreMod/pull/904/files change recipes for those cards?

Yes, it does
New recipes were done based on new module characteristics. And there is no problem to merge this PR much earlier than https://github.com/GTNewHorizons/NewHorizonsCoreMod/pull/904/files

@Dream-Master Dream-Master merged commit 77af221 into master Aug 4, 2024
2 checks passed
@Dream-Master Dream-Master deleted the easify-extractors branch August 4, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants