Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory optimization #432

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Memory optimization #432

merged 2 commits into from
Oct 29, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Oct 26, 2024 •
edited
Loading

The patched method creates a int[3] array with coords x y z for every method call

And that method gets called a lot when you have nuclear reactors

ic2 reactor alloc spam

@Alexdoru Alexdoru marked this pull request as ready for review October 29, 2024 22:44
mitchej123
mitchej123 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@mitchej123 mitchej123 merged commit 8e381c1 into master Oct 29, 2024
1 check passed
@mitchej123 mitchej123 deleted the memory branch October 29, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchej123 mitchej123 mitchej123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexdoru @mitchej123