Skip to content
This repository has been archived by the owner on May 25, 2024. It is now read-only.

Prevent machine explosion for Universal fluid engine #246

Closed
wants to merge 7 commits into from

Conversation

Reflex18
Copy link

Currently this machine takes in fluids and then outputs power based on the current input. When the world is loading in this machine will take in fluids then consume all of it and exploding due to over amping.

Therefore this PR will remove the function of the dynamo exploding and instead the engine will just void all excessive power generation while also consuming the fuel.

Currently this machine takes in fluids and then outputs power based  on the current input. When the world is loading in this machine will take in fluids then consume all of it and exploding due to over amping.

Therefore this PR will remove the function of the dynamo exploding and instead the engine will just void all excessive power generation while also consuming the fuel.
@AbdielKavash AbdielKavash requested a review from a team March 18, 2024 07:39
Copy link
Member

@BlueWeabo BlueWeabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on Dream's request, you should instead make it so that it doesn't blow up in the first few ticks of it running. 1.5x recipe time check worth of ticks should be fine for this to prevent explosion on world reload.

@Dream-Master Dream-Master added the ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Mar 24, 2024
@Dream-Master Dream-Master removed the ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Apr 28, 2024
@Dream-Master
Copy link
Member

@Reflex18 any news here ?

@Reflex18
Copy link
Author

I asked help within the discord and Steelux took up the ticket. Thanks to Steelux with the following ticket.
#256

@Reflex18 Reflex18 closed this May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants