This repository has been archived by the owner on May 25, 2024. It is now read-only.
CoALs: Add missing styrene-butadiene variants for AssLine recipes. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-QFT, I am left with a surfeit of Styrene-Butadiene rubber.
The Assembly Line recipes for pumps allow both Styrene-Butadiene Rubber rings and Silicone Rubber rings, similarly the conveyors allow for either plate, using the
@ringAnySyntheticRubberor@plateAnySyntheticRubberoredict entries. But the code to derive Component Assembly Line recipes only use the first oredict entry, so in the CoAL I can only use Silicone Rubber.This changes that in the least invasive way I could see. As noted in the comment, it is a bit fragile, i.e., if the ordering in the oredict list changes it will probably stop working again. If y'all have alternative suggestions I'm all ears :-)
Screenshots of a couple of the added recipes: