Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

make gt tool to be selected by ae2 nei handler #29

Closed
wants to merge 2 commits into from
Closed

Conversation

Glease
Copy link
Collaborator

@Glease Glease commented Dec 20, 2023

fix GTNewHorizons/GT-New-Horizons-Modpack#15149 by reverting to previous behavior.

HOWEVER, it's not clear if this reverting is needed. While this behavior change is purely unintetional, whether its revert is needed is not a no brainer and needs team decision. It's highly suggested to merge AFTER that decision is made. This PR can be simply closed if it was decided a revert is not desirable.

citing myself on discord

this is an unintentional change and can be reverted at ease without breaking single use tool. however, I'm not sure if the behavior they want is desirable any more
the encoded tool can either be single use tool or wrench, but not both. since ae2 probably cannot subsitute either for another (this is due to single use tool having only one oredict name, but typical crafting tool have 3 or more), once people realize how much single use tool can help ae2 performance, they will probably want to switch to single use tool. if we revert that change, then the default encoded tool will again not be what they want, i.e. they will complain again, that the encoded tool is not the single use variant

Copy link
Contributor

Warning: 2 uncommitted changes
#30

@Glease
Copy link
Collaborator Author

Glease commented Apr 2, 2024

So long and no interest. I'd assume a rollback is not intended?

@Dream-Master Dream-Master added On going freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version and removed On going freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version labels Apr 28, 2024
@eigenraven
Copy link
Member

It's been 1.5 years, I guess the way it currently works is fine

@eigenraven eigenraven closed this May 23, 2024
@Glease
Copy link
Collaborator Author

Glease commented May 23, 2024

While I agree with your statement, this is not that ancient 🤣

@eigenraven
Copy link
Member

Right, 0.5 years not 1.5 years 🤦‍♀️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ME patterns using reusable GT tools no longer calculate correctly.
3 participants