Fix baryonic perfection voiding one catalyst when recipe fails #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The T8 water plant multiblock is supposed to output all unused catalysts at the end of the recipe, whether it fails or succeeds. It also keeps track of an index
correctStartIndexto indicate which catalysts were used up, and when none are used this is set to-1. The problem with this is that when outputting unused catalysts, it will consider the catalysts atcurrentStartIndexandcurrentStartIndex + 1to be used for the recipe, which when the recipe fails will ignore the catalyst at index zero and void it.This PR implements a simple fix for the problem that should stop the plant from voiding unintentionally.