Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix T2 PCBFactory NEI structure preview #2638

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

RealSilverMoon
Copy link
Contributor

@RealSilverMoon RealSilverMoon commented Jun 5, 2024

NEI structure preview can't show T2&T3 PCBFactory. I add a check to fix it.
2
3
Though it's weird that T2 structure lost part of its back. Maybe something related to the structureDefinition or BlockRenderer6343.
84

@HoleFish
Copy link
Contributor

HoleFish commented Jun 5, 2024

GTNewHorizons/BlockRenderer6343#17 will be the better solution

@Quarri6343
Copy link
Member

If you can, please help me to implement a better UI for GTNewHorizons/BlockRenderer6343#17.
The workaround in this PR just makes dependencies worse

@Dream-Master Dream-Master requested a review from a team June 5, 2024 17:40
@Dream-Master
Copy link
Member

@RealSilverMoon

@RealSilverMoon
Copy link
Contributor Author

RealSilverMoon commented Jun 11, 2024

I have noticed that pr, but it doesn't seem to have anything to do with the tier. Blockrenderer calls survivalConstruct() to render multiblock, and the "tier" button only change the stacksize of trigger. However the pcb factory do not check stacksize at all, so i added it.

@HoleFish
Copy link
Contributor

HoleFish commented Jun 11, 2024

It means the tier should not be determined by the stacksize, but by the schematic configuration options in NEI preview
or the tier should be completely determined by the stacksize?

@RealSilverMoon
Copy link
Contributor Author

Normally yes. Other multi-tiered machines (like nanoForge) use stacksize on construct&survivalConstruct to determine machine tier, so this button would work:
image
While channel is used in structureElement to determine the tier of each pieces.

Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work for me

@Dream-Master Dream-Master merged commit 37fadf0 into GTNewHorizons:master Jul 28, 2024
2 checks passed
ah-OOG-ah pushed a commit to ah-OOG-ah/GT5-Unofficial that referenced this pull request Jul 31, 2024
* Fix T2 PCBFactory NEI structure preview

* compileOnly blockrenderer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants