Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase execution time limit to 20s #15668

Closed
wants to merge 1 commit into from

Conversation

Hikari1nVoid
Copy link

Target this:#15517
20sec should be adequate for general OC usage on large scale ME Networks and not get affected too hard from lnfinite loop apps.
Feel free to edit the number as long as AE2 getItemsInNetwork([filter:table]):table method does not fail in a Stargate base.

@Dream-Master Dream-Master requested a review from a team March 7, 2024 16:55
@boubou19 boubou19 mentioned this pull request Mar 10, 2024
@boubou19
Copy link
Member

5 seconds is already big, so 20s has the potential of destroying all the computer execution code. Feel free to do that in SP or on your own server, but we can't merge this in the pack because big server owners will then suddently have issues with their player experiencing weird behaviors with OC.

@boubou19 boubou19 closed this Mar 10, 2024
@Hikari1nVoid
Copy link
Author

5 seconds is already big,

This is for vanilla.

20s has the potential of destroying all the computer execution code.

This will not affect all OCs that are currently running.Changes will take effect once they are rebooted.And 20s is a "general number"and open for any modification.

And get root access for every GTNH server to modify this code is not that practical.And Server owners will not accept random guys' suggestion to change this config.

Just a random shitposting after I found out I'm the only one believes the execution limit is way too short on discord...this is closed and I probably cannot do anything about this.

@Hikari1nVoid Hikari1nVoid deleted the patch-2 branch March 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants