-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Draconic Evolution Information Tablet‘s image offline resources #15550
Conversation
@NealDeal34 did you check the license? Can this pictures be used outside this webpage ? |
@Dream-Master I think you don't need to worry about this at all,it's just a way the mod author to use image as an external resource in manual.The official cited webpages were as follows (eg.)https://raw.githubusercontent.com/brandon3055/Random-Bits/master/DE%20Tablet%20Images/ECore/ECore1.png in en_US version and (eg.)http://imgur.com/jj2j1nY.png in zh_CN version.Actually what i did is the way also provided by official in https://www.curseforge.com/minecraft/mc-mods/draconic-evolution/files/2234347 to slove the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License seems fine; however; I'd rather that we either:
- Offer a link to download and do this
- Make a separate mod that can be downloaded and makes these available
- Some other option for the subset of people with this problem to be able to download and have available offline
Increasing the size of this repo with binary objects, and the size of the pack for something that impacts a very small subset of the player base isn't worth it IMHO. How many people get to draconic in the pack, and how many of those are running offline and want to use the guide book? I'd wager less than 0.1%
Maybe make it available as a resource pack instead? They are adding them on mod/textures/gui/ so it should be possible. |
This is a non issue because we already do it for BLS with each major release: https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/tree/master/config/txloader/forceload/betterloadingscreen/textures/backgrounds And it takes only a minute to produce a release with the github action. We have time before reaching a point where it becomes unbearable. For hot mods repos i can understand, but for this one, it's not a big deal. |
Sorry,but i'm confused that you mean do it or not,for this mod? Thanks for guys advises @mitchej123 because i'm think about it and try to redirect the source url for special regions player who can't download the images normally.But it's not easy for searching a stable image hosting service and need some time. |
@NealDeal34 After some discussion with @Dream-Master we think it's better to have this as a ressource pack. We will offer it to download somewhere for the people interested in it. Can you change this into a ressource pack please? |
The Draconic Evolution Information Tablet load pictures by accessing appointed website and downloading it to appointed path,but for someone who were offline or in a special network environment that can't visit the website,those iamges could not loaded correctly,so i crate this path and files to load it directly to slove the problem.