Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Draconic Evolution Information Tablet‘s image offline resources #15550

Closed
wants to merge 3 commits into from

Conversation

NealDeal34
Copy link

The Draconic Evolution Information Tablet load pictures by accessing appointed website and downloading it to appointed path,but for someone who were offline or in a special network environment that can't visit the website,those iamges could not loaded correctly,so i crate this path and files to load it directly to slove the problem.

@Dream-Master Dream-Master requested a review from a team February 18, 2024 09:13
@Dream-Master
Copy link
Member

@NealDeal34 did you check the license? Can this pictures be used outside this webpage ?

@NealDeal34
Copy link
Author

@NealDeal34 did you check the license? Can this pictures be used outside this webpage ?

@Dream-Master I think you don't need to worry about this at all,it's just a way the mod author to use image as an external resource in manual.The official cited webpages were as follows (eg.)https://raw.githubusercontent.com/brandon3055/Random-Bits/master/DE%20Tablet%20Images/ECore/ECore1.png in en_US version and (eg.)http://imgur.com/jj2j1nY.png in zh_CN version.Actually what i did is the way also provided by official in https://www.curseforge.com/minecraft/mc-mods/draconic-evolution/files/2234347 to slove the problem.
The mod official license about that is "Art and sound assets are released under the Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International (CC BY-NC-SA 4.0), a summary of which can be found at: https://creativecommons.org/licenses/by-nc-sa/4.0/",What I said is quite verbose because i know exactly what I'm doing and do hope you can permit it,although this change significantly affected the size of the modpack.Thank you very much.

Copy link
Contributor

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License seems fine; however; I'd rather that we either:

  1. Offer a link to download and do this
  2. Make a separate mod that can be downloaded and makes these available
  3. Some other option for the subset of people with this problem to be able to download and have available offline

Increasing the size of this repo with binary objects, and the size of the pack for something that impacts a very small subset of the player base isn't worth it IMHO. How many people get to draconic in the pack, and how many of those are running offline and want to use the guide book? I'd wager less than 0.1%

@Ethryan
Copy link
Contributor

Ethryan commented Feb 25, 2024

Maybe make it available as a resource pack instead?

They are adding them on mod/textures/gui/ so it should be possible.

@boubou19 boubou19 mentioned this pull request Mar 10, 2024
@boubou19
Copy link
Member

This is a non issue because we already do it for BLS with each major release: https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/tree/master/config/txloader/forceload/betterloadingscreen/textures/backgrounds And it takes only a minute to produce a release with the github action. We have time before reaching a point where it becomes unbearable.

For hot mods repos i can understand, but for this one, it's not a big deal.

@NealDeal34
Copy link
Author

This is a non issue because we already do it for BLS with each major release: https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/tree/master/config/txloader/forceload/betterloadingscreen/textures/backgrounds And it takes only a minute to produce a release with the github action. We have time before reaching a point where it becomes unbearable.

For hot mods repos i can understand, but for this one, it's not a big deal.

Sorry,but i'm confused that you mean do it or not,for this mod? Thanks for guys advises @mitchej123 because i'm think about it and try to redirect the source url for special regions player who can't download the images normally.But it's not easy for searching a stable image hosting service and need some time.
And,just to clarify,no one's feeling and needs in game should be ignore if the problem could be solve,right?:)

@boubou19
Copy link
Member

@NealDeal34 After some discussion with @Dream-Master we think it's better to have this as a ressource pack. We will offer it to download somewhere for the people interested in it. Can you change this into a ressource pack please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants