Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize performance when rendering ender tanks / chests #13

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Oct 3, 2024

  • stop rendering the portal and hedron texture when the ender chest is closed
  • stop rendering the portal and hedron texture for the ender tank when rendering as an inventory item
  • only render the portal and hedron texture for the ender tank when within 16 blocks

None of the method signature changed are used outside of this mod, so it will not cause any crash. All the rendering works as intended which provides a big fps boost, or should as say it doesn't tank the fps as much as before.

@Dream-Master Dream-Master requested a review from a team October 3, 2024 14:42
@Dream-Master Dream-Master requested a review from a team October 3, 2024 16:12
Copy link
Contributor

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update CCL as discussed

@Alexdoru Alexdoru merged commit 9364db8 into master Oct 3, 2024
1 check passed
@Alexdoru Alexdoru deleted the rendering-optimisations branch October 3, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants