Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RenderHelper.disableStandardItemLighting() from RenderParticleGen #51

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Aug 29, 2024

Was causing items lighting to be incorrect

Before
image

After
image

@Caedis Caedis requested review from a team and mitchej123 August 29, 2024 11:12
@Caedis Caedis enabled auto-merge (squash) August 29, 2024 11:18
@boubou19
Copy link
Member

still tho, why is the particle generator still darkened as a whole?

@Caedis
Copy link
Member Author

Caedis commented Aug 29, 2024

No idea

@Caedis Caedis merged commit 0b4a807 into master Sep 1, 2024
1 check passed
@Caedis Caedis deleted the fixLighting branch September 1, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants