-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warpward as an allowed potion for the blood pendant #46
Conversation
I noticed in botania that there is a number of pedants for potion effects but none for warp ward. However, there are potions in botania for warp ward.
I’m in a meeting today, but I’ll throughly review this as soon as I’m done <3 |
If you look at the code, you'll have noticed that was intentional. Keeping mana stored is easy. An inventory of potions can become a nuisance. This item would pretty much eclipse all other items that provide warp control and thus not be good for balance. |
Ehhhhh I disagree based on former descriptions in magic dev, but let me take a look at the code |
Lmfao, yeah probably just needs some tweaking, but expected balancing is around the soul brazier, which I will note, already does literally this at HV for essentia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Balance issues, and strong preference to reject. A config option must be provided at minimum.
You're going to need to be way more specific than just "balancing issues" what are your exact qualms Like I just noted there's precedent for this, even if it's in different mods, this is effectively just a re-implemented version of the soul brazier but using Botania instead of thaumcraft which provides interesting cross magic mod compatibility and interaction which will help foster actual reasons for people to go into Botania in the pack. A topic Botania is sorely lacking at the moment |
Brazier has:
Pendant just runs off a sun- or coal-charged battery |
Brazier has:
Pendant just runs off a sun- or coal-charged battery
Sorry, I didn't mean to edit your comment, mobile's interface is terrible |
gotta agree with combusterf (and Abdiel) that A) this looks clearly intentional and B) that mana upkeep is more trivial than soul brazier |
So increase the passive cost significantly or add the passive nerfs that Botania is supposed to have I suppose, or both frankly, I don't see why we should pass up on great interactions that will help foster continuing to bring Botania into the fold because of that lmfao, Botania as a whole has continued to struggle to find its place in GTNH because it isn't well integrated and I do fully believe this will help foster that even if only a little more. Going to point this out though since it's been said repeatedly against me, this is GTNH, the original's author's intention has relatively little impact on the grand scale of things since this isn't their fork. |
Could you add a cap to the pendant and if the warp goes over it, it breaks the pendant? Like you can only use it at low warp, but when you have many warp you need to use other machinations |
@Reflex18 any news on this or should we close this? |
I would say close it as i don't think i have the skill to create the full rework of the pendant that was required to balance it inline with the pack. |
I noticed in botania that there is a number of pedants for potion effects but none for warp ward. However, there are potions in botania for warp ward.
I have set the effect to be allowed to provide another option to deal with warp for players that also invest into the botania side of magic.
This pedant drains a constant amount of mana from the player which requires investment into botania to provide upkeep and does not remove warp from the player at all.