Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean coremod and stop using COMPUTE_FRAMES which triggers unwanted class loading #21

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Clean coremod and stop using COMPUTE_FRAMES which triggers unwanted class loading #21

merged 5 commits into from
Oct 28, 2023

Conversation

Alexdoru
Copy link
Member

No description provided.

@Dream-Master Dream-Master requested a review from a team October 11, 2023 21:20
Glease
Glease approved these changes Oct 28, 2023
View reviewed changes
Copy link

@Glease Glease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit target matching via checked exceptions thrown is a very creative way of doing asm. glad we no longer have this.

@Dream-Master Dream-Master merged commit b264eca into master Oct 28, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix-classloading branch October 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glease Glease Glease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexdoru @Glease @Dream-Master