-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli-upload #81
cli-upload #81
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgosgeorgos amazing work, see my comments, mostly minor changes/refactor and points of discussion.
Add cli-upload. Signed-off-by: Giorgio Giannone <[email protected]>
fad21d4
to
9503dbc
Compare
Signed-off-by: Giorgio Giannone <[email protected]>
For the moment we don't have a direct way (for example |
The BaseSettings from pedantic are directly initialized from the env variables (where the upper case env var is read into the corresponding lower case class attribute). |
Signed-off-by: georgosgeorgos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting there :)
Fixed it. Thanks. When using upload functionality locally, the server can be |
in principle the strtobool is not needed, you can simply set |
Signed-off-by: georgosgeorgos <[email protected]>
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last bit, then it's good to go
Signed-off-by: georgosgeorgos <[email protected]>
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
There is a problem with GitHub Action related to this issue - actions/runner#667. Thanks @jannisborn for finding it. |
Minor update of upload customization.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a minor rephrasing in the docs. Good to go, besides the CLA issue.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: GitHub Action.
|
cli-upload
Add
upload
functionality to the command line. It gives the user the possibility to upload specific artifacts on a server.Given a specific
version
for an algorithm:- check if the folder
bucket/algorithm_type/algorithm_name/algorithm_application/version/
exists.cli-upload relies on
minio
and has been tested locally usingdocker-compose
.cli-upload can be used to upload on a cloud or local server.
How to use cli-upload
Following the example in the README (in the
Saving a trained algorithm for inference via the CLI command
section) and assuming a trained model in/tmp/test_cli_upload
, run:gt4sd-upload --training_pipeline_name paccmann-vae-trainer --model_path /tmp/test_cli_upload --training_name fast-example --target_version fast-example-v0 --algorithm_application PaccMannGPGenerator