Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sds popup #165

Merged
merged 35 commits into from
Mar 17, 2020
Merged

New sds popup #165

merged 35 commits into from
Mar 17, 2020

Conversation

HemalPatelBC
Copy link
Contributor

Description

Motivation and Context

Type of Change (Select One and Apply Github Label)

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • [x ] Chrome
  • [ x] Firefox
  • Safari

Checklist:

libs/packages/components/src/lib/popup/popup.module.ts Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.module.ts Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.directive.ts Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.directive.ts Outdated Show resolved Hide resolved
libs/packages/components/karma.conf.js Outdated Show resolved Hide resolved
libs/component-sample/src/lib/component-sample.module.ts Outdated Show resolved Hide resolved
apps/sam-design-system-site/src/app/app.component.html Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.directive.ts Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.directive.ts Outdated Show resolved Hide resolved
libs/packages/components/src/lib/popup/popup.directive.ts Outdated Show resolved Hide resolved
@GSA GSA deleted a comment from davereed Mar 11, 2020
@HemalPatelBC HemalPatelBC merged commit b3d5d1a into master Mar 17, 2020
@HemalPatelBC HemalPatelBC deleted the new-sds-popup branch March 17, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants