Created new branch for collapse component #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemalPatelBC
requested review from
christyhermansen,
davereed and
yerramshilpa
as code owners
davereed
requested changes
Jan 28, 2020
libs/packages/components/src/lib/collapse/collapse.component.ts
Outdated
Show resolved
Hide resolved
libs/packages/components/src/lib/collapse/collapse.directive.ts
Outdated
Show resolved
Hide resolved
libs/packages/components/src/lib/collapse/collapse.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/packages/components/src/lib/collapse/collapse.component.html
Outdated
Show resolved
Hide resolved
libs/component-sample/src/lib/feature/collapse-sample/collapse-sample.component.ts
Outdated
Show resolved
Hide resolved
libs/component-sample/src/lib/feature/collapse-sample/collapse-sample.component.html
Outdated
Show resolved
Hide resolved
davereed
requested changes
Jan 29, 2020
| <p | ||
| id="collapseID" | ||
| [sdsCollapse]="isCollapsedContent" | ||
| class="usa-accordion__content bg-base-lighter margin-top-1"> |
There was a problem hiding this comment.
Let's not use usa-accordion__content class in the example. It's not incorrect but it may confuse the implementing developer that this is being used for collapse.
| } | ||
|
|
||
|
|
||
| ngOnInit() {} |
| import { CollapseDirective } from './collapse.directive'; | ||
|
|
||
| @NgModule({ | ||
| declarations: [SdsCollapseComponent, CollapseDirective], | ||
| declarations: [ CollapseDirective], |
libs/packages/components/src/lib/collapse/collapse.directive.spec.ts
Outdated
Show resolved
Hide resolved
davereed
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Collapse Component
Type of Change (Select One and Apply Github Label)
Screenshots (if appropriate):
Which browsers have you tested?
Checklist: