Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly target response check for implemented-requirement/statement #952

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Dec 3, 2024

Committer Notes

Fix #939.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them? Explained in the issue linked to this pull request.
  • If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa self-assigned this Dec 3, 2024
@aj-stein-gsa aj-stein-gsa linked an issue Dec 3, 2024 that may be closed by this pull request
12 tasks
@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review December 3, 2024 18:32
@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner December 3, 2024 18:32
@aj-stein-gsa aj-stein-gsa marked this pull request as draft December 3, 2024 18:33
@aj-stein-gsa aj-stein-gsa force-pushed the 939-fix-missing-response-components branch from cb7faa2 to 767ce75 Compare December 3, 2024 18:42
@wandmagic
Copy link
Collaborator

            <expect id="missing-response-components" target="//statement" test="count(by-component) gt 0" level="ERROR">
                <formal-name>Missing Response Components</formal-name>
                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/6-security-controls/#response-overview"/>
                <message>Each implemented requirement MUST have at least one by-component reference to the source component implementing it.</message>
            </expect>

I ended up doing this

@aj-stein-gsa aj-stein-gsa mentioned this pull request Dec 3, 2024
5 tasks
@aj-stein-gsa aj-stein-gsa force-pushed the 939-fix-missing-response-components branch from 767ce75 to 5c35e34 Compare December 3, 2024 19:01
@aj-stein-gsa aj-stein-gsa force-pushed the 939-fix-missing-response-components branch from 5c35e34 to df81b19 Compare December 3, 2024 20:04
@aj-stein-gsa
Copy link
Contributor Author

I will reopen this PR to point to the #953 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

by-component constraint enforced in wrong location
2 participants