Add inter-boundary-communication-has-direction constraint #950
+107
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-ruf
reviewed
Dec 2, 2024
| <component uuid="66666666-0000-4000-9000-000000000006" type="interconnection"> | ||
| <title>External API Connection</title> | ||
| <description> | ||
| <p>Secure connection to an external API for data enrichment.</p> | ||
| </description> | ||
| <prop name="interconnection-security" value="vpn" ns="https://fedramp.gov/ns/oscal"/> | ||
| <prop name="interconnection-direction" value="in/out" ns="https://fedramp.gov/ns/oscal"/> | ||
| <prop name="direction" value="incoming" ns="https://fedramp.gov/ns/oscal"/> |
There was a problem hiding this comment.
the "direction" property is core OSCAL. Please drop the @ns
There was a problem hiding this comment.
OK re this feedback and #938 (comment), we are putting in the new core direction and connection-security and will eventually drop those with prefixed with interconnection-?
There was a problem hiding this comment.
the "direction" property is core OSCAL. Please drop the
@ns
I'm keeping the FedRAMP namespace until the core OSCAL changes are implemented. Otherwise, the constraint fails.
DimitriZhurkin
force-pushed
the
add-inter-boundary-communication-has-direction
branch
from
3b3415d
to
a068aba
Compare
Gabeblis
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Add the
inter-boundary-communication-has-directionconstraint, which tests the following scenario:Every inter-boundary communication component has at least one network traffic
directionproperty, with no more than oneincomingand no more than oneoutgoingtraffic direction property.Related issue: #930.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.