Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up fedramp-external-constraints.xml File #944

Closed

Conversation

Gabeblis
Copy link

Committer Notes

This PR aims to clean up the fedramp-external-constraints.xml file. The only changes were removing repeated context blocks, organizing constraints alphabetically, and keeping spacing uniform.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable to this PR. This is just a small cleanup within an individual file.
    - [ ] If applicable, does this PR reference the issue it addresses and explain how it addresses the issue? Not applicable to this PR. This is just a small cleanup within an individual file.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 27, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 27, 2024 14:59
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 27, 2024
Copy link

@DimitriZhurkin DimitriZhurkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@Gabeblis Gabeblis requested a review from a team November 27, 2024 16:02
wandmagic
wandmagic previously approved these changes Nov 27, 2024
@Gabeblis Gabeblis requested a review from a team November 27, 2024 16:06
@Gabeblis Gabeblis force-pushed the constraints/cleanup-constraints-file branch 2 times, most recently from a52e583 to fbb2794 Compare November 29, 2024 15:12
@Gabeblis Gabeblis force-pushed the constraints/cleanup-constraints-file branch from fbb2794 to 9144677 Compare November 29, 2024 15:19
@Gabeblis Gabeblis closed this Nov 29, 2024
@Gabeblis Gabeblis deleted the constraints/cleanup-constraints-file branch November 29, 2024 15:21
@Gabeblis Gabeblis restored the constraints/cleanup-constraints-file branch November 29, 2024 15:21
@Gabeblis Gabeblis reopened this Nov 29, 2024
@Gabeblis Gabeblis force-pushed the constraints/cleanup-constraints-file branch from d099c33 to 9ffcad9 Compare November 29, 2024 15:35
@Gabeblis Gabeblis closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants