Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/party name #878

Merged
merged 14 commits into from
Nov 12, 2024
Merged

Feature/party name #878

merged 14 commits into from
Nov 12, 2024

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 7, 2024

Committer Notes

add party has name constraint

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner November 7, 2024 15:48
@wandmagic wandmagic changed the base branch from master to develop November 7, 2024 15:48
@wandmagic
Copy link
Collaborator Author

#874

@aj-stein-gsa aj-stein-gsa linked an issue Nov 7, 2024 that may be closed by this pull request
14 tasks
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 7, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraint looks good. Just some changes for consistency.

Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whichever way we go with the constraint id, it should be consistent throughout all the file names so that it is future-proof and easier to maintain. After this is addressed, I'm ready to approve this PR 😄

Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wandmagic constraint runs as expected. Nice work. Once you rename it I'll approve.

Gabeblis
Gabeblis previously approved these changes Nov 8, 2024
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rene2mt
Rene2mt previously approved these changes Nov 12, 2024
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 👍🏾

@wandmagic wandmagic dismissed stale reviews from Rene2mt and Gabeblis via 62f43da November 12, 2024 18:47
@wandmagic wandmagic merged commit 402065a into GSA:develop Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that all parties have names
5 participants