-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/party name #878
Feature/party name #878
Conversation
Co-authored-by: Rene Tshiteya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constraint looks good. Just some changes for consistency.
Co-authored-by: Gabeblis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whichever way we go with the constraint id, it should be consistent throughout all the file names so that it is future-proof and easier to maintain. After this is addressed, I'm ready to approve this PR 😄
src/validations/constraints/content/ssp-party-has-name-INVALID.xml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/party-has-name-FAIL.yaml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/party-has-name-PASS.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wandmagic constraint runs as expected. Nice work. Once you rename it I'll approve.
Co-authored-by: Gabeblis <[email protected]>
…ramp-automation into feature/party-name
….xml Co-authored-by: Gabeblis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good 👍🏾
Co-authored-by: A.J. Stein <[email protected]>
Committer Notes
add party has name constraint
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.