Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-characteristics 'has-assurance-level' constraints #701

Conversation

Gabeblis
Copy link

Committer Notes

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

Description

Added system-characteristics 'has-assurance-level' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

  • Added constraints has-identity-assurance-level, has-authenticator-assurance-level, and has-federation-assurance-level to fedramp-external-constraints.xml.
  • Added pass and fail yaml tests for all of the above constraints.
  • Edited ssp-all-VALID.xml to ensure all constraints pass correctly.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner September 18, 2024 14:51
@Gabeblis Gabeblis changed the title Add system-characteristics 'has-assurance-level' constraints & tests Add system-characteristics 'has-assurance-level' constraints Sep 18, 2024
@aj-stein-gsa
Copy link
Contributor

@Gabeblis you cool with me committing those recs and merging in this PR after that or would you like to discuss?

@Gabeblis
Copy link
Author

@Gabeblis you cool with me committing those recs and merging in this PR after that or would you like to discuss?

Can we briefly discuss?

@aj-stein-gsa
Copy link
Contributor

@Gabeblis you cool with me committing those recs and merging in this PR after that or would you like to discuss?

Can we briefly discuss?

Thanks for discussing, sir! I appreciate the conversation. I will ref #675 because we need to look at examples like this review to discuss wording of certain types of messages, and we need consistent info before (not after) constraint writing about that.

@aj-stein-gsa aj-stein-gsa merged commit e1bfe5c into GSA:feature/external-constraints Sep 18, 2024
3 checks passed
aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024
* Add system-characteristics 'has-assurance-level' constraints & tests

* Make uniform wording for informational findings per PR review

---------

Co-authored-by: A.J. Stein <[email protected]>
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
* Add system-characteristics 'has-assurance-level' constraints & tests

* Make uniform wording for informational findings per PR review

---------

Co-authored-by: A.J. Stein <[email protected]>
Rene2mt pushed a commit to Rene2mt/fedramp-automation that referenced this pull request Sep 27, 2024
* Add system-characteristics 'has-assurance-level' constraints & tests

* Make uniform wording for informational findings per PR review

---------

Co-authored-by: A.J. Stein <[email protected]>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* Add system-characteristics 'has-assurance-level' constraints & tests

* Make uniform wording for informational findings per PR review

---------

Co-authored-by: A.J. Stein <[email protected]>
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants