-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system-characteristics 'categorization-has' constraints #671
Add system-characteristics 'categorization-has' constraints #671
Conversation
bec0eb1
to
e6a1686
Compare
@Gabeblis is out of office, so I will rebase this PR again recent changes to the target branch so I can complete a review and potentially merge. |
e6a1686
to
91eb95b
Compare
Sigh, I borked the rebase. 🤦 Will have to go for a take two! Assigning myself as the guilty party for now. |
91eb95b
to
5ee358a
Compare
@aj-stein-gsa I successfully rebased onto the target branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I will integrate my very minor PR feedback and merge. 🫡
2caa772
to
22f1615
Compare
65f2030
into
GSA:feature/external-constraints
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <[email protected]>
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <[email protected]>
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <[email protected]>
* Added system-characteristics 'categorization-has constraints and tests * Adjust path style and message wording per my PR feedback --------- Co-authored-by: A.J. Stein <[email protected]>
Committer Notes
Description
Added system-characteristics 'categorization-has' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.
Changes
{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.