Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-characteristics 'categorization-has' constraints #671

Conversation

Gabeblis
Copy link

@Gabeblis Gabeblis commented Sep 10, 2024

Committer Notes

Description

Added system-characteristics 'categorization-has' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

  • Added constraints categorization-has-correct-system-attribute, categorization-has-information-type-id to fedramp-external-constraints.xml.
  • Added pass and fail yaml tests for all of the above constraints.
  • Edited ssp-all-INVALID.xml to ensure all constraints fail correctly.

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner September 10, 2024 14:53
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/categorization-has branch 2 times, most recently from bec0eb1 to e6a1686 Compare September 11, 2024 15:55
@aj-stein-gsa
Copy link
Contributor

@Gabeblis is out of office, so I will rebase this PR again recent changes to the target branch so I can complete a review and potentially merge.

@aj-stein-gsa aj-stein-gsa force-pushed the constraints/system-characteristics/categorization-has branch from e6a1686 to 91eb95b Compare September 16, 2024 18:27
@aj-stein-gsa
Copy link
Contributor

Sigh, I borked the rebase. 🤦 Will have to go for a take two! Assigning myself as the guilty party for now.

@aj-stein-gsa aj-stein-gsa self-assigned this Sep 16, 2024
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/categorization-has branch from 91eb95b to 5ee358a Compare September 16, 2024 19:51
@Gabeblis
Copy link
Author

Sigh, I borked the rebase. 🤦 Will have to go for a take two! Assigning myself as the guilty party for now.

@aj-stein-gsa I successfully rebased onto the target branch.

aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 16, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I will integrate my very minor PR feedback and merge. 🫡

aj-stein-gsa
aj-stein-gsa previously approved these changes Sep 16, 2024
@aj-stein-gsa aj-stein-gsa force-pushed the constraints/system-characteristics/categorization-has branch from 2caa772 to 22f1615 Compare September 17, 2024 05:23
@aj-stein-gsa aj-stein-gsa merged commit 65f2030 into GSA:feature/external-constraints Sep 17, 2024
3 checks passed
aj-stein-gsa added a commit that referenced this pull request Sep 24, 2024
* Added system-characteristics 'categorization-has constraints and tests

* Adjust path style and message wording per my PR feedback

---------

Co-authored-by: A.J. Stein <[email protected]>
aj-stein-gsa added a commit that referenced this pull request Sep 25, 2024
* Added system-characteristics 'categorization-has constraints and tests

* Adjust path style and message wording per my PR feedback

---------

Co-authored-by: A.J. Stein <[email protected]>
Rene2mt pushed a commit to Rene2mt/fedramp-automation that referenced this pull request Sep 27, 2024
* Added system-characteristics 'categorization-has constraints and tests

* Adjust path style and message wording per my PR feedback

---------

Co-authored-by: A.J. Stein <[email protected]>
brian-ruf pushed a commit to brian-ruf/fedramp-automation that referenced this pull request Nov 8, 2024
* Added system-characteristics 'categorization-has constraints and tests

* Adjust path style and message wording per my PR feedback

---------

Co-authored-by: A.J. Stein <[email protected]>
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

2 participants