Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Baseline Profiles Do Not Contain JSON Catalog Links #103

Closed
rgauss opened this issue Jun 8, 2021 · 5 comments · Fixed by #128
Closed

JSON Baseline Profiles Do Not Contain JSON Catalog Links #103

rgauss opened this issue Jun 8, 2021 · 5 comments · Fixed by #128
Assignees
Labels
bug Something isn't working

Comments

@rgauss
Copy link

rgauss commented Jun 8, 2021

Describe the bug

The JSON representation of baseline profiles only contain XML rlinks (example) for the catalog back-matter resource.

There should be an rlink to a JSON representation of that catalog with an application/oscal.catalog+json media type (example with a currently incorrect extension due to reported issue).

Who is the bug affecting?

Anyone using JSON representations of baseline profiles.

What is affected by this bug?

The ability to resolve catalog controls for baseline profiles.

When does this occur?

Always

@rgauss rgauss added the bug Something isn't working label Jun 8, 2021
@ohsh6o ohsh6o self-assigned this Jun 8, 2021
@ohsh6o
Copy link
Contributor

ohsh6o commented Jun 8, 2021

Thanks for your report, @rgauss. We will look at this in conjunction with usnistgov/oscal-content#59.

@ohsh6o
Copy link
Contributor

ohsh6o commented Jun 10, 2021

@rgauss I (as part of FedRAMP) discussed this with the NIST OSCAL developers. The pipeline work as surfaced here and usnistgov/oscal-content#59 will require significant modifications that will not be addressed by OSCAL tooling, not just FedRAMP's baseline updates using it. I will review a workaround solution and/or manual effort for the 1.0.0 release potentially, but cannot commit to that at this time. I will update this issue and its tracking tags accordingly.

@rgauss
Copy link
Author

rgauss commented Jun 11, 2021

@ohsh6o, thanks for looking into it! We can implement temporary workarounds on our end in the meantime.

@ohsh6o
Copy link
Contributor

ohsh6o commented Jun 17, 2021

@rgauss I am going to attempt to work on a CI/CD fix that is mutually beneficial in the interim, for our FedRAMP's own 1.0.0 release, that will be beneficial to FedRAMP and NIST. Stay tuned and I will appropriately message in this bug report. Thanks again!

@ohsh6o
Copy link
Contributor

ohsh6o commented Jul 6, 2021

I have been working on this locally on my workstation but it might not be ready for 1.0.0. I published a workaround by publishing all the profile formats in parallel in #103 to address the particular need, but it will continue to write a more programmatic check, and potentially revert this change and not include all formats in the future. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants