specify party name is required #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
approved these changes
Nov 14, 2024
aj-stein-gsa
requested changes
Nov 14, 2024
Co-authored-by: A.J. Stein <[email protected]>
12 tasks
12 tasks
aj-stein-gsa
requested changes
Nov 15, 2024
There was a problem hiding this comment.
So I talked with others on the team and they actually agreed that the short-name is not a requirement.
Because the diff crosses a deleted line, I cannot put in a suggestion, so @wandmagic, can you edit this to remove the previous sentence that requires short-name? Only name is really necessary.
aj-stein-gsa
approved these changes
Nov 15, 2024
Co-authored-by: A.J. Stein <[email protected]>
14 tasks
Rene2mt
approved these changes
Nov 18, 2024
aj-stein-gsa
added a commit
that referenced
this pull request
Nov 19, 2024
* Update oscal-metadata.md * Update content/documentation/general-concepts/oscal-metadata.md Co-authored-by: A.J. Stein <[email protected]> * Update oscal-metadata.md * Update oscal-metadata.md Co-authored-by: A.J. Stein <[email protected]> --------- Co-authored-by: A.J. Stein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specify that party name is required in the documentation