Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding methods for user / group management #74

Merged
merged 15 commits into from
Sep 22, 2023

Conversation

Rdornier
Copy link
Contributor

@Rdornier Rdornier commented Sep 5, 2023

Hello @ppouchin,

I've added some new methods to easily found out if a user is admin / group owner and to retrieve a user group by its ID
I think it would be cool to access these attributes too.

All the best,
Rémy.

@ppouchin
Copy link
Member

Sorry, I haven't had the time to take a look since I came back.
I'll check that ASAP at the start of next week.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (b2c030d) 95.43% compared to head (6283706) 95.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
+ Coverage     95.43%   95.46%   +0.02%     
- Complexity     1147     1154       +7     
============================================
  Files            45       45              
  Lines          3047     3064      +17     
  Branches        243      244       +1     
============================================
+ Hits           2908     2925      +17     
  Misses           78       78              
  Partials         61       61              
Files Changed Coverage Δ
src/main/java/fr/igred/omero/Client.java 100.00% <100.00%> (ø)
.../java/fr/igred/omero/meta/ExperimenterWrapper.java 96.55% <100.00%> (+0.71%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppouchin
Copy link
Member

ppouchin commented Sep 22, 2023

Sorry @Rdornier , I have one question: is there an advantage to add a getAllAvailableGroups method in Client when the same can be achieved (AFAIK) using client.getUser(userId).getGroups() or client.getUser(userName).getGroups()?

@ppouchin ppouchin self-requested a review September 22, 2023 11:21
@Rdornier
Copy link
Contributor Author

Hello @ppouchin
I didn't know that it was possible to get access to all available groups from client.getUser(userId).getGroups(). You can obviously remove getAllAvailableGroups, as it only introduces duplicates

@ppouchin ppouchin merged commit 33bac4f into GReD-Clermont:main Sep 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants