Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to delete multiple tables with one API call #63

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

Rdornier
Copy link
Contributor

Hello @ppouchin,

In order to minimize the numbre of API calls, I add some methods to be able to delete multiple tables with one API call.
I wasn't able to find a way to do it with the existing methods. That's why I added them.

Rémy.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (3f0fa88) 95.49% compared to head (7886b53) 95.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
+ Coverage     95.49%   95.53%   +0.04%     
- Complexity     1133     1138       +5     
============================================
  Files            45       45              
  Lines          3017     3025       +8     
  Branches        236      236              
============================================
+ Hits           2881     2890       +9     
  Misses           78       78              
+ Partials         58       57       -1     
Impacted Files Coverage Δ
src/main/java/fr/igred/omero/Client.java 100.00% <100.00%> (ø)
src/main/java/fr/igred/omero/GatewayWrapper.java 95.19% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ppouchin
Copy link
Member

I changed the "deleteFiles" argument to use a Long array instead of a list, although I don't know if it's any better, but I think it's more consistent with the rest of the library (list of longs are usually passed as arrays).

@Rdornier
Copy link
Contributor Author

Perfect, Thanks !

@ppouchin ppouchin merged commit bea2171 into GReD-Clermont:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants