Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL fixes #43

Merged
merged 6 commits into from
Dec 8, 2022
Merged

CodeQL fixes #43

merged 6 commits into from
Dec 8, 2022

Conversation

ppouchin
Copy link
Member

@ppouchin ppouchin commented Dec 8, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 92.09% // Head: 92.10% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cd9c3f7) compared to base (a745816).
Patch coverage: 90.40% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              5_9_3      #43    +/-   ##
==========================================
  Coverage     92.09%   92.10%            
- Complexity      849      890    +41     
==========================================
  Files            38       39     +1     
  Lines          2544     2648   +104     
  Branches        190      211    +21     
==========================================
+ Hits           2343     2439    +96     
- Misses          155      157     +2     
- Partials         46       52     +6     
Impacted Files Coverage Δ
src/main/java/fr/igred/omero/roi/ROIWrapper.java 94.48% <71.42%> (-1.45%) ⬇️
...ain/java/fr/igred/omero/meta/PlaneInfoWrapper.java 87.71% <87.71%> (ø)
.../java/fr/igred/omero/repository/PixelsWrapper.java 91.27% <90.90%> (-0.20%) ⬇️
...n/java/fr/igred/omero/repository/ImageWrapper.java 90.59% <94.44%> (+1.21%) ⬆️
.../java/fr/igred/omero/annotations/TableWrapper.java 94.23% <100.00%> (+0.76%) ⬆️
.../main/java/fr/igred/omero/util/LibraryChecker.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ppouchin ppouchin merged commit 40d01e4 into 5_9_3 Dec 8, 2022
@ppouchin ppouchin deleted the codeql-fixes branch December 8, 2022 14:59
ppouchin added a commit that referenced this pull request Jan 18, 2023
* Bump version
* Bump SciJava version
* Update versions used by maven.yml
* Add PlaneInfoWrapper class and set image origin in IJ calibration
* Add setName method to ROIWrapper and use values from the IJ_Property as names
* Change default values for shape colors
* Add setFill to ShapeWrapper
* Compute interval from deltaT
* Add new dependency to pom.xml (ome-xml)
* Add new dependency check in LibraryChecker
* Remove useless final modifiers
* CodeQL fixes (#43)
* Replace instanceof with reflection in ShapeList
* Check NumberFormatException
* Refactor and improve TableWrapper tests
* Improve setUp/cleanUp for IJ table tests
* Rename variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant