-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableWrapper rows clipped to 1000 #56
Comments
Right. This is because the TablesFacility from the Java Gateway limits the number of rows retrieved to 1000 if no number is given. I could retrieve the information and always load the whole table, but I think it would be wiser to follow what the OME team did and only provide one method to retrieve rows in a provided range and one method to get the basic info (with no data), or even just the number of rows. That would incite devs to check the size is "acceptable" before downloading a table. |
Ok, Thanks.
Yes, it could be great to have a method in TableWrapper like |
I still have an issue. I've written the code below List<TableWrapper> tables = repoWrapper.getTables(client).stream().filter(e -> e.getName().contains(tableName)).collect(Collectors.toList());
if(!tables.isEmpty()) {
TableWrapper table = tables.get(0);
TableData tableData = client.getGateway().getFacility(TablesFacility.class).getTable(client.getCtx(), table.getFileId(), 0, table.getRowCount(),
IntStream.range(0, table.getColumnCount()).toArray());
return new TableWrapper(tableData);
} but Could you initialize TableWrapper with the file Id when we invoke |
Hello,
I've a problem dealing with TableWrapper. When I get a table from OMERO, the size of data (number of rows) are clipped to 1000 even if the table has more than 1000 rows. Strange thing : the rowCount indicates the correct number of rows.
Edit : I'm using 5.12.2 version of simple-omero-client
The text was updated successfully, but these errors were encountered: