Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix fasttext build #194

Merged
merged 4 commits into from
May 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -Ur requirements.txt
pip install -Ur docs/requirements.txt
pip install -e .
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -Ur requirements.txt
pip install -Ur styling_requirements.txt
pip install -Ur tests/requirements.txt
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -Ur requirements.txt
pip install -Ur tests/requirements.txt
python setup.py develop
Expand All @@ -38,6 +39,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -Ur requirements.txt
pip install -Ur tests/requirements.txt
python setup.py develop
Expand Down
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -321,4 +321,7 @@
- Add an example of how to use URI for parsing from and uploading to
- Improve error handling of `path_to_retrain_model`
- Bug-fix pre-processor error
- Add verbose override and improve verbosity handling in retrain
- Add verbose override and improve verbosity handling in retrain
- Bug-fix the broken FastText installation using `fasttext-wheel` instead of `fasttext` (
see [here](https://github.com/facebookresearch/fastText/issues/512#issuecomment-1534519551)
and [here](https://github.com/facebookresearch/fastText/pull/1292)).
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ testpaths = [

[tool.pylint.ini_options]
DJANGO_SETTINGS_MODULE = "settings"

[build-system]
requires = ["setuptools", "wheel", "pybind11"]
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pymagnitude-light
colorama>=0.4.3
poutyne
gensim>=4.2.0
fasttext
fasttext-wheel
pandas
urllib3
cloudpathlib[s3, gs, azure]