[Continuations] Support new LLVM #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was long deprecated and now has been removed upstream. These were only used in asserts, and these asserts are going to turn into no-ops with opaque pointers, so we can just remove them now without replacement.
PointerType::getWithSamePointeeType was removed in upstream LLVM, but we rely on it in typed pointer mode. Add a helper function that calls the LLVM function for old LLVM, and returns an untyped pointer for new LLVM. This helper can be removed once typed pointer support is no longer needed.
|
@chuang13 fyi - this PR does not require porting to the internal repo |
Test summary for commit 45a3cb4CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove uses of typed pointer functions removed in upstream LLVM.
isOpaqueOrPointeeTypeMatcheswithout replacement. These were just used in asserts that would soon turn into no-ops anyways.PointerType::getWithSamePointeeTypewhich falls back to untyped pointers on new LLVM. This helper can be removed once untyped pointer support is no longer needed.(This is a GPUOpen port of an already landed internal fix.)