[Continuation] Update to deprecated LLVM API #2872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isOpaqueOrPointeeTypeMatches and PointerType::getWithSamePointeeType are now deprecated.
jasilvanus
reviewed
Dec 8, 2023
Comment on lines
+195
to
+196
| New = Builder.CreateCast(Inst->getOpcode(), MemSrc, | ||
| PointerType::get(Inst->getType(), Data.Addrspace)); |
There was a problem hiding this comment.
I think this is incorrect: inst->getType() is the pointer type, but PointerType::get expects the element type.
There was a problem hiding this comment.
I think it is not a case anymore with opaque pointers. PointerType::get is just taking ->getContext() from the Type, but I can change this to PointerType::get(Inst->getType()->getContext() ?
There was a problem hiding this comment.
With opaque pointers, this is just returning a ptr addrspace(..) type, so it is correct (because the element type does not matter and is ignored).
But this code needs to function with typed pointers for the time being, and in that case it is incorrect.
|
Covered in different review. |
mariusz-sikora-at-amd
deleted the
masikora/continuation-deprecated-api
branch
Test summary for commit 15af9caCTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isOpaqueOrPointeeTypeMatches and PointerType::getWithSamePointeeType are now deprecated.