Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doom Eternal RT regression #2862

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

LLJJDD
Copy link
Contributor

@LLJJDD LLJJDD commented Dec 4, 2023

Root cause:
When building ELF with helper thread, a new lgc::Pipeline object is created, which does not set useGpurt.

Solution:
Set useGpurt for that lgc::Pipeline.

Root cause:
When building ELF with helper thread, a new lgc::Pipeline object is created,
which does not set useGpurt.

Solution:
Set useGpurt for that lgc::Pipeline.
@LLJJDD LLJJDD requested a review from a team as a code owner December 4, 2023 03:25
@amdvlk-admin
Copy link

Test summary for commit 1a58e6d

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LLJJDD LLJJDD merged commit 39c5ac6 into GPUOpen-Drivers:dev Dec 4, 2023
9 checks passed
@LLJJDD LLJJDD deleted the fix-doom-crash branch December 4, 2023 08:24
qiaojbao pushed a commit that referenced this pull request Jan 2, 2024
Root cause:
When building ELF with helper thread, a new lgc::Pipeline object is created,
which does not set useGpurt.

Solution:
Set useGpurt for that lgc::Pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants