Add support for SHT_RELA in vkgc #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently LLVM generates relocations in an ELF SHT_REL section. To allow for changing the compiler to use SHT_RELA instead, this patch updates vkgcElfReader and vkgcPipelineDumper to support both section types.
|
TBH I am not too happy with this. vkgcElfReader is all based around known section names instead of section types, and now it is assuming that only one of ".rel.text" and ".rela.text" will exist. |
Test summary for commit 631d2e2CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Flakebi
approved these changes
Nov 29, 2023
jayfoad
commented
Nov 29, 2023
| reloc->useExplicitAddend = false; | ||
| auto *section = m_sections[m_relocSecIdx]; | ||
|
|
||
| if (section->secHead.sh_type == SHT_REL) { |
There was a problem hiding this comment.
For consistency I should probably have checked the section name here instead of the type. But I could not bear to add a string compare to this otherwise fast function.
There was a problem hiding this comment.
Moving in the right direction, even if it's by a little bit, is a good thing ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently LLVM generates relocations in an ELF SHT_REL section. To allow for changing the compiler to use SHT_RELA instead, this patch updates vkgcElfReader and vkgcPipelineDumper to support both section types.