Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Deduplicate constant data tables #2854

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add tests for Deduplicate constant data tables #2854

merged 1 commit into from
Dec 7, 2023

Conversation

mariusz-sikora-at-amd
Copy link
Contributor

No description provided.

@mariusz-sikora-at-amd mariusz-sikora-at-amd requested a review from a team as a code owner November 29, 2023 08:08
nhaehnle
nhaehnle reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can especially the first test be simplified a bit?

@amdvlk-admin
Copy link

Test summary for commit 1b11387

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@mariusz-sikora-at-amd
Copy link
Contributor Author

Can especially the first test be simplified a bit?

Done.

@amdvlk-admin
Copy link

Test summary for commit 2b5d3dc

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@mariusz-sikora-at-amd mariusz-sikora-at-amd mentioned this pull request Nov 30, 2023
Merged
nhaehnle
nhaehnle approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mariusz-sikora-at-amd mariusz-sikora-at-amd force-pushed the masikora/pub-TestsForDuplicateGV branch from 2b5d3dc to 7403425 Compare December 7, 2023 10:31
@amdvlk-admin
Copy link

Test summary for commit 7403425

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35163/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34000/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@mariusz-sikora-at-amd mariusz-sikora-at-amd merged commit 844c30f into GPUOpen-Drivers:dev Dec 7, 2023
10 checks passed
@mariusz-sikora-at-amd mariusz-sikora-at-amd deleted the masikora/pub-TestsForDuplicateGV branch December 7, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@nhaehnle nhaehnle nhaehnle approved these changes

@AMD-dwang AMD-dwang Awaiting requested review from AMD-dwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariusz-sikora-at-amd @amdvlk-admin @nhaehnle @Flakebi