-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for addition of disjoint flag from upstream llvm #2851
Conversation
There seems to be lots of diff caused by replacing CRLF by Unix line endings -- could you please factor that out into a separate commit? Edit: I just realized that this is what you meant with "un-dosifying" -- I thought "dosify" was just a rare verb that I could not make sense of :) |
I could make it a separate commit if that's preferable. It just makes the porting process a bit more of a hassle. But I do agree that it adds unnecessary mess. |
Either is fine with me if it really helps the porting process. |
Upstream llvm is introducing a new disjoint flag that makes it easier to determine when an or instruction was originally an add - which can be useful in some optimisations. Since neither of the affected tests were auto-generated, I've added something that allows for the disjoint flag to be optionally present.
1217b26
to
ad2b7bd
Compare
I made it a separate commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(Would squashing on merge help the porting issue?)
I'm going to port it as 2 commits - I think it makes sense for the same reason as for here (keep the noise as a separate commit). |
Test summary for commit 1217b26CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit ad2b7bdCTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Upstream llvm is introducing a new disjoint flag that makes it easier to determine when an or instruction was originally an add - which can be useful in some optimisations.
Since neither of the affected tests were auto-generated, I've added something that allows for the disjoint flag to be optionally present.