lgc: Optimally insert return block during cps lowering #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the original function does not have `return` instruction, we don't
need the runtime check to exit, thus no need to insert return block.
A handy command to fixup the test check:
sed -i 's/llvm.amdgcn.set.inactive.i32/llvm.amdgcn.set.inactive.{{(chain.arg.)?}}i32/g' lgc/test/Transforms/CpsLowering/*
ruiling
force-pushed
the
opt-cps-scheduler
branch
from
1e8c5ef to
7a995d4
Compare
Test summary for commit 7a995d4CTS tests (Failed: 0/139021)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Flakebi
approved these changes
Oct 12, 2023
nhaehnle
reviewed
Oct 12, 2023
|
|
||
| builder.SetInsertPoint(chainBlock); | ||
| if (chainBlock) | ||
| builder.SetInsertPoint(chainBlock); |
There was a problem hiding this comment.
This could be moved in the îfabove, right?
There was a problem hiding this comment.
Yes, it can, I just move this out of the above if for the sake of clear code (compiler should be able to simplify the branch here), this line should better stay with the code below not the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original function does not have
returninstruction, we don't need the runtime check to exit, thus no need to insert return block.A handy command to fixup the test check:
sed -i 's/llvm.amdgcn.set.inactive.i32/llvm.amdgcn.set.inactive.{{(chain.arg.)?}}i32/g' lgc/test/Transforms/CpsLowering/*