Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgc: Pass Layer and ViewportIndex from VS to HS/GS and from HS to DS #2743

Merged
merged 7 commits into from
Oct 6, 2023
Merged

lgc: Pass Layer and ViewportIndex from VS to HS/GS and from HS to DS #2743

merged 7 commits into from
Oct 6, 2023

Conversation

xazhangAMD
Copy link
Contributor

DX spec allows SV_RenderTargetArrayIndex/SV_ViewportArrayIndex to be used in those shader stages.

@xazhangAMD
lgc: Pass Layer and ViewportIndex from VS to HS/GS and from HS to DS
d403700 
DX spec allows SV_RenderTargetArrayIndex/SV_ViewportArrayIndex to be
used in those shader stages.
@xazhangAMD xazhangAMD requested a review from a team as a code owner October 4, 2023 14:04
@GPUOpen-Drivers GPUOpen-Drivers deleted a comment from amdvlk-admin Oct 4, 2023
@GPUOpen-Drivers GPUOpen-Drivers deleted a comment from amdvlk-admin Oct 4, 2023
@GPUOpen-Drivers GPUOpen-Drivers deleted a comment from amdvlk-admin Oct 4, 2023
@amdvlk-admin
Copy link

Test summary for commit c319647

CTS tests (Failed: 0/139021)
  • Built with version 1.3.5.2
    • Ubuntu 22.04, Navi3x
    • Passed: 41144/69517 (59.2%)
    • Failed: 0/69517 (0.0%)
    • Not Supported: 28373/69517 (40.8%)
    • Warnings: 0/69517 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41178/69504 (59.2%)
    • Failed: 0/69504 (0.0%)
    • Not Supported: 28326/69504 (40.8%)
    • Warnings: 0/69504 (0.0%)

nhaehnle
nhaehnle reviewed Oct 4, 2023
View reviewed changes
lgc/patch/PatchInOutImportExport.cpp Outdated Show resolved Hide resolved
lgc/patch/PatchInOutImportExport.cpp Outdated Show resolved Hide resolved
lgc/patch/PatchInOutImportExport.cpp Outdated Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
lgc/patch/PatchResourceCollect.cpp Show resolved Hide resolved
@amdvlk-admin
Copy link

Test summary for commit 8b1c8bb

CTS tests (Failed: 0/139021)
  • Built with version 1.3.5.2
    • Ubuntu 22.04, Navi3x
    • Passed: 41144/69517 (59.2%)
    • Failed: 0/69517 (0.0%)
    • Not Supported: 28373/69517 (40.8%)
    • Warnings: 0/69517 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41178/69504 (59.2%)
    • Failed: 0/69504 (0.0%)
    • Not Supported: 28326/69504 (40.8%)
    • Warnings: 0/69504 (0.0%)

nhaehnle
nhaehnle reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I think you missed a spot.

lgc/patch/PatchInOutImportExport.cpp Outdated Show resolved Hide resolved
@xazhangAMD
Copy link
Contributor Author

Thanks, but I think you missed a spot.

Yeah, I missed that. Will update soon.

@amdvlk-admin
Copy link

Test summary for commit 0bcbcd9

CTS tests (Failed: 0/139021)
  • Built with version 1.3.5.2
    • Ubuntu 22.04, Navi3x
    • Passed: 41144/69517 (59.2%)
    • Failed: 0/69517 (0.0%)
    • Not Supported: 28373/69517 (40.8%)
    • Warnings: 0/69517 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41178/69504 (59.2%)
    • Failed: 0/69504 (0.0%)
    • Not Supported: 28326/69504 (40.8%)
    • Warnings: 0/69504 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit 7cb1a16

CTS tests (Failed: 0/139021)
  • Built with version 1.3.5.2
    • Ubuntu 22.04, Navi3x
    • Passed: 41144/69517 (59.2%)
    • Failed: 0/69517 (0.0%)
    • Not Supported: 28373/69517 (40.8%)
    • Warnings: 0/69517 (0.0%)
    Ubuntu 20.04, Navi2x
    • Passed: 41177/69504 (59.2%)
    • Failed: 0/69504 (0.0%)
    • Not Supported: 28327/69504 (40.8%)
    • Warnings: 0/69504 (0.0%)

nhaehnle
nhaehnle approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xazhangAMD xazhangAMD merged commit 6680b1e into dev Oct 6, 2023
14 checks passed
@Flakebi Flakebi deleted the lgc_to_pass_layer_vpindex_to_next_stage branch October 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xazhangAMD @amdvlk-admin @nhaehnle