Decouple primitive generated query from xfb #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary for commit 7ebe376CTS tests (Failed: 0/208496)
Rhel 9.0, Gfx10Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
nhaehnle
previously approved these changes
Sep 27, 2023
The query for primitive generated (pgq) is independent of transform feedback workflow. This PR aims to decouple pgq from xfb by taking pgq as a pipeline option. - Add a new interface `PipelineOptions::enablePrimGeneratedQuery`. - Guard the old interface `ApiXfbOutData::forceEnablePrimStats` with llpc version.
|
V1: Rebase. |
Test summary for commit 56bde82CTS tests (Failed: 0/139021)
Ubuntu 22.04, Navi3xUbuntu 20.04, Navi2x |
nhaehnle
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query for primitive generated (pgq) is independent of transform feedback workflow. This PR aims to decouple pgq from xfb by taking pgq as a pipeline option.
PipelineOptions::enablePrimGeneratedQuery.ApiXfbOutData::forceEnablePrimStatswith llpc version.