Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charts for GPP-app and GPP publicatiebank #2

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Dec 4, 2024

@sergei-maertens
Copy link
Contributor

Todo:

@SilviaAmAm I can confirm this is how it's set up :)

Copy link
Contributor

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may be confusing some component names?

  • gpp-publicatiebank: django backend (formerly ODRC/woo-publications)
  • gpp-app: .net app (formerly ODPC)
  • gpp-burgerportaal: .net app (I think), formerly ODBP

A little more documentation is available here: https://gpp-publicatiebank.readthedocs.io/en/latest/introduction/index.html

charts/GPP-publicatiebank/Chart.yaml Outdated Show resolved Hide resolved
charts/GPP-publicatiebank/README.md Outdated Show resolved Hide resolved
charts/GPP-publicatiebank/templates/configmap.yaml Outdated Show resolved Hide resolved
@SilviaAmAm
Copy link
Contributor Author

I think you may be confusing some component names?

I think so, so if I understand correctly:

  • gpp-publicatiebank: old registratie component
  • gpp-app: old icatt-odpc

I will swap them

@SilviaAmAm SilviaAmAm mentioned this pull request Dec 4, 2024
@SilviaAmAm SilviaAmAm force-pushed the feature/add-app-and-publicatie-bank branch from 3a23a2c to 59221a6 Compare December 4, 2024 16:12
Copy link
Contributor

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the Django project, can't say much about the gpp-app :)

charts/GPP-publicatiebank/README.md Outdated Show resolved Hide resolved
charts/GPP-publicatiebank/templates/configmap.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@felixcicatt felixcicatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can remove the dependency on Redis in the GPP-app, everything looks good to me, thanks!

charts/GPP-app/Chart.yaml Outdated Show resolved Hide resolved
charts/GPP-app/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/GPP-app/templates/deployment.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@felixcicatt felixcicatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felixcicatt felixcicatt merged commit d2abee1 into main Dec 11, 2024
@felixcicatt felixcicatt deleted the feature/add-app-and-publicatie-bank branch December 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODRC: Create Helm charts
3 participants