Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODRC: implement informatiecategorie resource #14

Closed
3 tasks done
Tracked by #1
sergei-maertens opened this issue Sep 3, 2024 · 8 comments · Fixed by #30, #31, #32 or #67
Closed
3 tasks done
Tracked by #1

ODRC: implement informatiecategorie resource #14

sergei-maertens opened this issue Sep 3, 2024 · 8 comments · Fixed by #30, #31, #32 or #67

Comments

@sergei-maertens
Copy link
Contributor

sergei-maertens commented Sep 3, 2024

Every published document belongs to a particular information category. The possible information categories are defined in a "waardelijst" published as part of the DiWoo standard (informatiecategorielijst in diwoo-metadata-lijsten.xsd). Additionally, organisaties want to define their own information categories (see #9).

The publication tool needs access to these categories so the correct metadata can be attached to documents.

Roughly the schema of InformatieCategorie would look like:

InformatieCategorie:
  type: object
  properties:
    identifier:
      type: string
      format: uri
    order:
      type: number  # integer
    name:
      type: string
    namePlural:
      type: string
    definition:
      type: string
    origin:
      type: string
      enum:
        - waardelijst
        - zelf_toegevoegd  # can be edited, others cannot

Waardelijst: https://standaarden.overheid.nl/tooi/waardelijsten/expression?lijst_uri=https%3A%2F%2Fidentifier.overheid.nl%2Ftooi%2Fset%2Fscw_woo_informatiecategorieen%2F3

  • Define model for InformatieCategorie and integrate it in the admin interface
    • Search on identifier and name
    • Order by order
    • List filter on origin
    • identifier is never editable
  • Add READ endpoint(s) /api/v1/informatiecategorieen
  • Add management command to populate the table from the waardelijst
    • Result must dump a django fixture (using natural keys!)
    • Fixture must be loaded automatically on deploys (post-migrate hook) so that the docker image contains the necessary data
@sergei-maertens sergei-maertens added this to the ODRC: Basis milestone Sep 3, 2024
@sergei-maertens
Copy link
Contributor Author

Estimate at 4-5 days

@sergei-maertens sergei-maertens moved this to Backlog in GPP-Woo Sep 3, 2024
bart-maykin added a commit that referenced this issue Sep 13, 2024
sergei-maertens added a commit that referenced this issue Sep 18, 2024
…informatie-categorie-resource-backup

🗃️ [#14] added informatie categorie model
@github-project-automation github-project-automation bot moved this from In progress to Done in GPP-Woo Sep 18, 2024
bart-maykin added a commit that referenced this issue Oct 9, 2024
bart-maykin added a commit that referenced this issue Oct 10, 2024
bart-maykin added a commit that referenced this issue Oct 10, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in GPP-Woo Oct 10, 2024
@sergei-maertens
Copy link
Contributor Author

re-opening for testing reasons

@github-project-automation github-project-automation bot moved this from Testing to In progress in GPP-Woo Oct 10, 2024
@sergei-maertens sergei-maertens moved this from In progress to Testing in GPP-Woo Oct 10, 2024
@MarcoKlerks
Copy link
Contributor

@bart-maykin @sergei-maertens
Ik zie dat KOOP tegenwoordig een extra informatiecategorie in de waardenlijst heeft staan: "inspanningsverplichting art 3.1 Woo".

Ik wil dat deze categorie straks niet in het ODPC of ODBP getoond wordt, maar dat alle handmatig toegevoegde informatiecategorieën in de DiWoo-sitemap als "inspanningsverplichting art 3.1 Woo" opgenomen worden. Hoe lossen we dat op?

Verder ziet de oplossing er overigens netjes uit!

@MarcoKlerks MarcoKlerks moved this from Testing to In review in GPP-Woo Oct 11, 2024
@sergei-maertens
Copy link
Contributor Author

@MarcoKlerks kan je daar een aparte US voor opvoeren? Ik denk dat we deze zullen kunnen hardcoden zodat alle zelf-toegevoegde categorieën automatisch naar die categorie omgekat worden - we kunnen een attribuut diWooInformatieCategorie in de API opnemen die deze vertaling doet zodat het burgerportaal hier niets mee hoeft te doen

@MarcoKlerks
Copy link
Contributor

@sergei-maertens, dat zal ik doen! Dan kan deze story naar Done, toch?

@sergei-maertens
Copy link
Contributor Author

inderdaad - als alles goed is, dan kan je deze story sluiten en dan gaat die vanzelf naar de "Done" kolom!

@github-project-automation github-project-automation bot moved this from In review to Done in GPP-Woo Oct 14, 2024
@MarcoKlerks MarcoKlerks added this to the Plateau 0 (MVP) milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment