review: using

GPP-Woo · Nov 25, 2024 · 2464b6c · 2464b6c
1 parent 3ab4f22
commit 2464b6c
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 11 deletions.
diff --git a/ODPC.Server/Features/Documenten/DocumentBijwerken/DocumentBijwerkenController.cs b/ODPC.Server/Features/Documenten/DocumentBijwerken/DocumentBijwerkenController.cs
@@ -30,7 +30,7 @@ public async Task<IActionResult> Put(string version, Guid uuid, PublicatieDocume
             }
 
             // document bijwerken
-            var putResponse = await client.PutAsJsonAsync(url, document, token);
+            using var putResponse = await client.PutAsJsonAsync(url, document, token);
 
             putResponse.EnsureSuccessStatusCode();
 

diff --git a/ODPC.Server/Features/Documenten/DocumentDownload/DocumentDownloadController.cs b/ODPC.Server/Features/Documenten/DocumentDownload/DocumentDownloadController.cs
@@ -22,12 +22,7 @@ public async Task<IActionResult> Get(string version, Guid uuid, CancellationToke
 
             var json = await response.Content.ReadFromJsonAsync<PublicatieDocument>(token);
 
-            if (json?.Eigenaar?.identifier != user.Id)
-            {
-                return NotFound();
-            }
-
-            return new DocumentDownloadResult(Request.Path, "Document downloaden");
+            return json?.Eigenaar?.identifier != user.Id ? NotFound() : new DocumentDownloadResult(Request.Path, "Document downloaden");
         }
     }
 }
diff --git a/ODPC.Server/Features/Documenten/InitialiseerDocument/InitialiseerDocumentController.cs b/ODPC.Server/Features/Documenten/InitialiseerDocument/InitialiseerDocumentController.cs
@@ -10,9 +10,10 @@ public class InitialiseerDocumentController(IOdrcClientFactory clientFactory) :
         public async Task<IActionResult> Post(string version, PublicatieDocument document, CancellationToken token)
         {
             using var client = clientFactory.Create("Initialiseer document");
+
             var url = $"/api/{version}/documenten";
 
-            var response = await client.PostAsJsonAsync(url, document, token);
+            using var response = await client.PostAsJsonAsync(url, document, token);
 
             response.EnsureSuccessStatusCode();
 

diff --git a/ODPC.Server/Features/Documenten/UploadBestandsdeel/UploadBestandsdeelController.cs b/ODPC.Server/Features/Documenten/UploadBestandsdeel/UploadBestandsdeelController.cs
@@ -25,9 +25,10 @@ public async Task<IActionResult> Put(string version, Guid docUuid, Guid partUuid
             content.Add(fileContent, "inhoud", file.FileName);
 
             using var client = clientFactory.Create("Upload bestandsdeel");
+
             var url = $"/api/{version}/documenten/{docUuid}/bestandsdelen/{partUuid}";
 
-            var response = await client.PutAsync(url, content, token);
+            using var response = await client.PutAsync(url, content, token);
 
             response.EnsureSuccessStatusCode();
 

diff --git a/ODPC.Server/Features/Publicaties/PublicatieBijwerken/PublicatieBijwerkenController.cs b/ODPC.Server/Features/Publicaties/PublicatieBijwerken/PublicatieBijwerkenController.cs
@@ -47,7 +47,7 @@ public async Task<IActionResult> Put(string version, Guid uuid, Publicatie publi
             }
 
             // publicatie bijwerken
-            var putResponse = await client.PutAsJsonAsync(url, publicatie, token);
+            using var putResponse = await client.PutAsJsonAsync(url, publicatie, token);
 
             putResponse.EnsureSuccessStatusCode();
 

diff --git a/ODPC.Server/Features/Publicaties/PublicatieRegistreren/PublicatieRegistrerenController.cs b/ODPC.Server/Features/Publicaties/PublicatieRegistreren/PublicatieRegistrerenController.cs
@@ -24,9 +24,10 @@ public async Task<IActionResult> Post(string version, Publicatie publicatie, Can
             }
 
             using var client = clientFactory.Create("Publicatie registreren");
+
             var url = $"/api/{version}/publicaties";
 
-            var response = await client.PostAsJsonAsync(url, publicatie, token);
+            using var response = await client.PostAsJsonAsync(url, publicatie, token);
 
             response.EnsureSuccessStatusCode();