Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Fix build issues on macOS 10.14 #7

Closed
wants to merge 1 commit into from
Closed

Fix build issues on macOS 10.14 #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2018

This fixes a build issue on macOS 10.14 (Mojave) where clang complained
that the header files <config.h> and <pinentry-curses.h> could not
be found.

Build errors before this patch: build_output.txt

This fixes a build issue on macOS 10.14 (Mojave) where clang complained
that the header files `<config.h>` and `<pinentry-curses.h>` could not
be found.
@fxcoudert
Copy link

This is more likely due to newest clang that to macOS version.

@jaredmichaelwilliams
Copy link

I was coming to do this as well haha, you beat me to it had to change
<config.h> to "config.h" in these files
./Source/pinentry-0.9.4/assuan/assuan-listen.c ./Source/pinentry-0.9.4/assuan/assuan-buffer.c ./Source/pinentry-0.9.4/assuan/assuan-util.c ./Source/pinentry-0.9.4/pinentry/password-cache.c ./Source/pinentry-0.9.4/pinentry/pinentry.c ./Source/pinentry-0.9.4/pinentry/argparse.c ./Source/pinentry-0.9.4/secmem/secmem.c
and <pinentry-curses.h> to "pinentry-curses.h"
in Source/main.m Source/AppDelegate.m

@kotashiratsuka
Copy link

👍

chrstphrchvz added a commit to chrstphrchvz/pinentry-mac that referenced this pull request Nov 13, 2020
As of Xcode 12, implicit function declarations are errors rather than
warnings. For reasons similar to GPGTools#7, pinentry-curses.c needs to include
"memory.h" (rather than <memory.h>) to find the declaration for
secmem_free(). (On macOS and other BSD OSes, a <memory.h> system header
exists and merely includes <string.h>.)
@sirn sirn mentioned this pull request Dec 30, 2020
@ghost ghost closed this by deleting the head repository Feb 25, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants