Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gns3 dependency on sentry-sdk #2423

Closed
mm1ke opened this issue Oct 7, 2024 · 3 comments
Closed

gns3 dependency on sentry-sdk #2423

mm1ke opened this issue Oct 7, 2024 · 3 comments

Comments

@mm1ke
Copy link
Contributor

mm1ke commented Oct 7, 2024

Hi,

sentry-sdk has some issues (details can be found at: [1]) which ultimately will result in removing this package from the gentoo main repository.
gns3-server has a dependency on sentry-sdk which would mean it would be removed too as we couldn't fulfill it's dependencies anymore. I'm wondering if it's possible to either remove the dependency or replace it with some other package? Also: Is it possible to run gns3 without sentry-sdk? What restrictions would we have?

[1] https://bugs.gentoo.org/937896

@grossmj
Copy link
Member

grossmj commented Oct 8, 2024

@mm1ke we are going to make the sentry-sdk dependency optional. It should be possible to run gns3 without sentry-sdk already.

@mm1ke
Copy link
Contributor Author

mm1ke commented Oct 13, 2024

@grossmj thanks for the information. happy to hear that :)

mm1ke added a commit to mm1ke/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and should be already possbile to run gns3 without it
GNS3/gns3-server#2423

Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
mm1ke added a commit to mm1ke/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and should be already possbile to run gns3 without it
GNS3/gns3-server#2423

Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
mm1ke added a commit to mm1ke/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and it should be already
possbile to run gns3 without it.
see: GNS3/gns3-server#2423

Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
mm1ke added a commit to mm1ke/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and it should be already
possbile to run gns3 without it.
see: GNS3/gns3-server#2423

Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and it should be already
possbile to run gns3 without it.

Bug: GNS3/gns3-server#2423
Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Oct 13, 2024
Upstream is going to make sentry-sdk optional and it should be already
possbile to run gns3 without it.

Bug: GNS3/gns3-server#2423
Bug: https://bugs.gentoo.org/937896
Signed-off-by: Michael Mair-Keimberger <[email protected]>
Closes: #38970
Signed-off-by: Michał Górny <[email protected]>
@grossmj
Copy link
Member

grossmj commented Oct 14, 2024

@mm1ke we are going to make the sentry-sdk dependency optional.

Actually, it is already optional. Nothing to change then :)

https://github.com/GNS3/gns3-server/blob/master/gns3server/crash_report.py#L18L24
https://github.com/GNS3/gns3-gui/blob/master/gns3/crash_report.py#L18L24

@grossmj thanks for the information. happy to hear that :)

No worries.

@grossmj grossmj closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants