WELCOME_SETUP=0

[MrVining]

It seems like there should be:
"WELCOME_SETUP=0"
between lines 49 and 50 of remote-install.sh.

I couldn't figure out how to make a comment on the file itself.

[eantowne]

Technically, it is not required, in fact some of the other variables that are instantiated and assigned values in that portion are most likely not even necessary.

Explanation:
An if statement in a bash script that includes a non-existent variable will evaluate to "nothing", and all of the comparisons using those variables are comparing to 1. Nothing will never == 1, therefore not declaring the variable and declaring the variable equal to 0 in this script are functionally the same.

Could it be changed? Yes
Does it need to be changed? No
Should it be changed? Maybe?

[MrVining]

I only noticed it missing because of the error message it currently throws on a fresh install of Ubuntu 22.04 server.

[eantowne]

What error are you getting?

On Tue, Mar 21, 2023 at 21:26 MrVining ***@***.***> wrote: I only noticed it missing because of the error message it currently throws on a fresh install of Ubuntu 22.04 server. — Reply to this email directly, view it on GitHub <#2202 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APZX5IYY2NBTQ3ESHJPHJRTW5JIMPANCNFSM6AAAAAAV73272Q> . You are receiving this because you commented.Message ID: ***@***.***>

-- Ean L. Towne ***@***.***

[MrVining]

gns3-remote-install.sh: line 304: [: ==: unary operator expected
gns3-remote-install.sh: line 457: [: ==: unary operator expected

[eantowne]

Hmmm, that is interesting, if you set the value as you suggest, does it resolve the issue?

[MrVining]

It sure does.

I should note that the install is successful regardless of the error message, or log message, whatever you want to call it.

[eantowne]

PR submitted, thank you! PR:2211