-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark interface style using QDarkStyle #3328
Open
JulianMato
wants to merge
6
commits into
GNS3:master
Choose a base branch
from
JulianMato:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JulianMato thanks for your contribution. The result is great excepting some black text in a few locations. Let me know if you need some help to finish this PR. |
@JulianMato do you have any plan to complete this PR? thanks 👍 |
I am going to finish this PR, just need to find time. |
Thanks a lot 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the "interface style" in the general settings panel/tab to have a "dark" theme, once selected QDarkStyle is called as a style sheet, recoloring the UI. This does require the addition of QDarkStyle in requirements.txt.
It's still a work in progress, currently the style and coloring work to the extent of my testing but there are some spacing issues in some UI elements. I am using the Charcoal style's code for the most part but can to re-write it with its own icons if needed.
This commit resolves issues #767 and #3208