-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of virtual sites and better compatibility with MARTINI 3 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gititnore and codeowners
Cleanup02
* Create styling module * Use f strings * Use indent size 4 * Return objects after forward fill * Remove folder
Add exceptions
…types_mass) that must be used in case there is no definition of the atom mass in the itp file of the molecule we want to optimize via fetch_cg_mass_itp(ns)
…orrectly make CG traj whole during optimization runs analysis + Fix dihedrals handling
Added handling of virtual sites + Fixed an issue in BI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all good imo, we can upload this to Pypi. I will stop making changes/commits for a while now, unless we find some bug.
giovannidoni
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in principle this is ready and well tested by Luca and me. This allows to use all virtual sites functions, except vs2 func 2, but we have enough to resolve issue #1.