Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ability to sort menu items by priority for CascadingMenu #4554

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Sep 9, 2024

The @jbrowse/core/ui/Menu has a function for sorting menu items by a priority attribute. The code for doing the same thing for @jbrowse/core/ui/CascadingMenu was missing though. This PR

  • adds the same code for sorting by priority to the @jbrowse/core/ui/CascadingMenu (was missing)
  • makes it so the "Display types" has a low priority to get sorted last
  • re-orders some items in the alignments/pileup display track menu items list

@cmdcolin cmdcolin merged commit 055ef35 into main Sep 10, 2024
4 checks passed
@cmdcolin cmdcolin deleted the reorder_menu branch September 10, 2024 13:55
@cmdcolin cmdcolin added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant